Proxy infinite loop #31846
Merged
Proxy infinite loop #31846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cro
force-pushed
the
proxy_infinite_loop
branch
from
f627bb6
to
c739127
Compare
|
Shouldn't this be merged to develop as well? It is still being hit by the bug |
|
@alexbleotu Yes, it well be. The current merge-forward to develop is blocked on another issue, but once that is resolved, this PR will be merged into develop. |
|
@rallytime Ok. Thanks! |
meggiebot
added
the
bugfix-bckport
|
Need in 2015.8 |
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Corrects a problem where proxies would flood the event bus and cause a pegged CPU when syncing grains.
What issues does this PR fix or reference?
Fixes #31728 and #31791.
Previous Behavior
Syncing grains for proxy would cause a recursive loop (event posted to bus, proxy reacts to event that would post same event to bus, etc)
New Behavior
Grains syncing and custom grains for proxies work without flooding the event bus.
Tests written?