Fix scaleway cloud provider and manage x86 servers #31883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on this guy. Let's merge it when Jenkins is happy again. |
|
Go Go Jenkins! |
cachedout
pushed a commit
that referenced
this pull request
Mar 15, 2016
Fix scaleway cloud provider and manage x86 servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the scaleway provider to take into account that Scaleway provides different types of X86 servers (aka C2) in addition to C1 arm servers.
It also fixes small errors preventing the driver from working.
What issues does this PR fix or reference?
Previous Behavior
Unable to use scaleway cloud provider.
New Behavior
Scaleway provider working, and able to manage different kind of servers
request.get_code()replaced byrequest.status_codeTests written?