fixing file.managed with requests lib #32315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the use of the requests lib when retrieving files via http. This worked in 2015.5, but stopped working in 2015.8.
In 2015.5 and before requests lib is the only way to retrieve files via a http proxy.
What issues does this PR fix or reference?
This issue was also mentioned as part of #23617 for the 2015.8 branch (@The-Loeki commented on 8 Oct 2015).
Previous Behavior
The following code downloads the file correctly in 2015.5, but retrieves an empty file in 2015.8.
Tests written?
No - a hint on how to write a test for this would be appreciated.
This was manually tested on 2015.8.8.2 on CentOS