Unbreak cron.file #32396
Merged
Unbreak cron.file #32396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra argument (skip_verify) was recently added to get_managed(), resulting in this error: Unable to manage file: get_managed() takes exactly 11 arguments (10 given) Also eliminate a variable that can remain uninitialized when running `salt-call`
|
I tested this fix manually, but feel free to consider this a working issue report if the correct fix should look different |
|
Hi @eradman Could you please fix this lint error? http://166.78.178.63:8080/job/PR/job/salt-pr-lint-n/851/violations/file/salt/states/cron.py/ Then we'll do a thorough review and hopefully get this in. Thanks! |
|
Go Go Jenkins! |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Apr 7, 2016
* commit '90b0a42a21dc11ca118ffbb679e0871f234c17bc': Unbreak cron.file (saltstack#32396) Unbreak timezone test for Gentoo (saltstack#32420)
|
Did this fix just not make into the 2016.3.1 point release because it doesn't have an issue tracking it? |
Closed
|
Hi @avandendorpe - this fix didn't make it into 2016.3.1 because it was submitted against the develop branch. I can backport it to 2016.3 now though to be included in 2016.3.2. Thank you for letting us know. |
rallytime
added
the
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unbreak cron.file
Previous Behavior
An extra argument (skip_verify) was recently added to get_managed(),
resulting in this error:
Unable to manage file: get_managed() takes exactly 11 arguments (10 given)