It doesn't seem like there was a populated salt dunder within the

[gladiatr72]

What does this PR do?

On v2015.8.8 .utils.boto() was choking on not finding __salt__['config.option']()
Additionally,.utils.boto._get_profile() was stomping on the region argument

What issues does this PR fix or reference?

This one--maybe others? :)

Previous Behavior

specifying a profile and a region would result in all boto_* calls being dispatched to us-east-1

Tests written?

No

It doesn't seem like there was a populated salt dunder within the salt.utils.boto namespace, so, that.

in .utils.boto._get_profile(), when a profile was specified, the getter
logic wasn't checking for the region argument being set.

[cachedout]

Could you clarify how you determined that this wasn't populated, please? It seems like this was working prior to this point.

[gladiatr72]

When trying to track down the disfunction I was experiencing with the boto modules' auth profile functionality, I installed a log directive with the within the profile argument test block. After determining that I had salt.utils logging set to crit (upped it to debug), I started seeing KeyError exceptions.

I added a get_profile = _get_profile to expose the function to the utils loader. Using ipython, I instantiated a _utils__ dict and was seeing the same problem. I grabbed a reference to utils.boto from sys.modules to examine the namespace and found salt.utils.boto.__salt__ to be empty.

Looking at salt.loader.utils(), the only dunder assigned to the pack dict is __context__.

---

(sidenote)

There is a version of modules.config.option in salt.utils.__init__. Perhaps a different topic, but regardless of the decision wrt to this patch, would it make sense to have the config.* logic encapsulated in a utility module that can either be imported or accessed via the utils dunder? I appreciate the addition of the utils loader for the purpose of easing distribution of custom utility module distribution, but injecting minion modules into the utility name space seems to be a bit upside down.

I look forward to your thoughts.

[ninjada]

I also, appear to be experiencing this issue.