Support remote sources in a source list #32691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2016
terminalmage
force-pushed
the
issue30151
branch
from
f671ee1
to
619cf9a
Compare
|
Some tests need to be updated, working on this now. |
terminalmage
force-pushed
the
issue30151
branch
from
619cf9a
to
97a6062
Compare
This commit modifies the source_list check so that remote sources (http(s), ftp, etc.) are not fetched more than once. To do so, it adds the use of ``__context__`` in ``cp.cache_file`` and ``file.source_list`` to prevent multiple fetches of a single file in the same salt run.
Added __context__ to test cases to reflect usage of __context__, and also added file.source_list to mocked funcs for archive.extracted unit test.
terminalmage
force-pushed
the
issue30151
branch
from
97a6062
to
cdcd960
Compare
|
Very nice. |
TheBigBear
added a commit
to TheBigBear/salt
that referenced
this pull request
Apr 22, 2016
Support remote sources in a source list (saltstack#32691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the source_list check so that remote sources
(http(s), ftp, etc.) are not fetched more than once. To do so, it
adds the use of
__context__incp.cache_fileandfile.source_listto prevent multiple fetches of a single file in thesame salt run.