Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mode should default to 'text' #32883

Merged
merged 1 commit into from Apr 27, 2016
Merged

mode should default to 'text' #32883

merged 1 commit into from Apr 27, 2016

Conversation

papertigers
Copy link
Contributor

@papertigers papertigers commented Apr 27, 2016 •
edited

What does this PR do?

Assign carbon.mode a default value.

What issues does this PR fix or reference?

#32882

Previous Behavior

Traceback (most recent call last):
  File "salt/utils/schedule.py", line 734, in handle_func
  File "salt/returners/carbon_return.py", line 300, in returner
  File "salt/returners/carbon_return.py", line 237, in _send
UnboundLocalError: local variable 'mode' referenced before assignment

New Behavior

[INFO    ] Returning information for job: req

Tests written?

No

@rallytime rallytime merged commit 20864cb into saltstack:develop Apr 27, 2016
@rallytime rallytime added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Apr 27, 2016
@rallytime rallytime mentioned this pull request Apr 28, 2016
Merged
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@papertigers @rallytime