Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework modules.mac_brew.latest_version to work around brew version inconsistency #33522

Merged
merged 8 commits into from
May 26, 2016

Conversation

jfindlay
Copy link
Contributor

What does this PR do?

Brew lists package versions differently for packages that are not installed vs installed if the version includes a package revision.

What issues does this PR fix or reference?

Previous Behavior

   -> integration.states.pkg.PkgTest.test_pkg_008_latest_with_epoch  ................................
       Traceback (most recent call last):
         File "/opt/salt/lib/python2.7/site-packages/salttesting/helpers.py", line 68, in wrap
           return caller(cls)
         File "/testing/tests/integration/states/pkg.py", line 328, in test_pkg_008_latest_with_epoch
           self.assertSaltTrueReturn(ret)
         File "/testing/tests/integration/__init__.py", line 1456, in assertSaltTrueReturn
           **(next(six.itervalues(ret)))
       AssertionError: False is not True. Salt Comment:
       The following packages failed to update: bash-completion

New Behavior

test_pkg_008_latest_with_epoch (integration.states.pkg.PkgTest)
[CPU:48.2%|MEM:49.1%|Z:0]  ... ok

Tests written?

Yes

@cachedout cachedout merged commit 0bc881b into saltstack:2016.3 May 26, 2016
@jfindlay jfindlay deleted the mac_pkg branch May 26, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants