Fix win servermanager #33558
Merged
Fix win servermanager #33558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
force-pushed
the
fix_win_servermanager
branch
from
f15f834
to
62a6bde
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes problem with where win_servermanager state would fail if run when already installed with the force option. Was returning an empty dictionary.
Also returns more detailed information about what was installed.
What issues does this PR fix or reference?
An issue Rob H was having.
Previous Behavior
win_servermanager state would fail if the item was already installed and force was set to True
New Behavior
win_servermanager state no longer fails. More detailed information is returned.
Tests written?
Yes