Allow validation of bundled certificates #33577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is not possible to validate bundled certificates as the get_pem_entry function expects only one certificate in the file. This change allows for the first certificate in the file to be extracted and validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to validate bundled certificates using the x509 module
Using the command.
salt-call x509.verify_signature /etc/pki/baruwa/certs/scanner.lab.topdog-software.com.pem signing_pub_key=/etc/pki/certbot/certs/certbot-staging-ca.pem/etc/pki/baruwa/certs/scanner.lab.topdog-software.com.pemcontains the certificate and the CA certificate appended for use with NginxPrevious Behavior
It was not possible to validate a bundled certificate, you would get the error
Passed invalid arguments: PEM does not contain a single entry of typeNew Behavior
It is now possible to validate a bundled certificate, the first certificate in
the bundle is extracted and used in the check.
Tests written?
No
Currently it is not possible to validate bundled
certificates as the get_pem_entry function expects
only one certificate in the file.
This change allows for the first certificate in the
file to be extracted and validated.