check rabbitmq version and use different api to validate a users pass… #33641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glomium Thanks for this. Could you have a look at the lint suggestions here, please? https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/2215/violations/file/salt/modules/rabbitmq.py/ |
cachedout
added
the
Pending-Discussion
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rabbitmq added in version 3.5.7 a cli command to check users credentials. The command executed by
modules/rabbitmq.pyto check the user credentials seems to an internal api, which was renamed or removed from rabbitmq.This PR introduces a version check (code adapted from line 58) and use the public API to validate the user credentials if rabbitmq >= 3.5.7. is detected - solving #33588
What issues does this PR fix or reference?
#33588
Tests written?
No