Added test mode to states.dockerng. Resolves #33632. #33659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danslimmon Would you mind rebasing this? There are merge conflicts. @terminalmage and @ticosax Any feedback here? |
cachedout
added
the
Pending-Discussion
danslimmon
force-pushed
the
dockerng-dryrun-33632
branch
from
97d6247
to
519c537
Compare
|
Rebased! EDIT: Whoa, wait, I did something really wrong merge-wise. Let me see what that was... EDIT: Should be fixed now. Fingers crossed on the tests. |
danslimmon
force-pushed
the
dockerng-dryrun-33632
branch
from
519c537
to
ef885c1
Compare
|
@danslimmon Looks better. I'm going to let this sit overnight since @ticosax is on the other side of the world and I'd like for him to have a chance to look it over. Thanks! |
|
Doesn't look like any comments came back so I'm going to go ahead and get this in. Thanks, @danslimmon |
|
👍 thanks @danslimmon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33632 by adding test mode awareness to
states.dockerng.volume_presentWhat issues does this PR fix or reference?
#33632.
Previous Behavior
Calling
salt <insert hostname> state.sls docker.test test=Truewould create a volume.New Behavior
Calling
salt <insert hostname> state.sls docker.test test=Truelogs what it would do but doesn't create anything.Tests written?
No, as this is a fix for the test mode of the state.