Gem integration test #33691
Gem integration test #33691
Conversation
| gem.sources_remove | ||
| ''' | ||
| sources_list = self.run_function('gem.sources_list') | ||
| source = 'http://gems.github.com' |
There was a problem hiding this comment.
This seems subject to change. I don't think this block is necessary.
|
Overall, I think this is starting to look pretty good. My main concern with these types of tests is that they tend to flake when the upstream service isn't online. Ultimately, I would like to move in a direction where we can test this stuff without relying on external services but this is fine for now. |
cachedout
added
the
Pending-Discussion
|
Sounds good. I'll make those changes. I'm not sure how to abstract the test away from the upstream service, unless we mock that potential output, but then it seem like we're just testing the mock, instead. Anyway, just thinking out loud. |
|
@jtand Yeah, you've got the issue exactly. There's a part of me that wants to just build out a shadow infrastructure to handle all of this but I somehow doubt that's going to be any more reliable. I have yet to really come up with a solution for this problem that I like. |
|
@cachedout Hmmm, I think something that would check to make sure the external resource is live before running any of the tests would help alleviate that issue some. |
|
That's a really good idea. A |
|
Yeah. I'll look into it and pm you with what I come up with. |
|
Cool. Should be easy. |
|
@jtand Lint fixup needed, please. |
|
On it. Local lint missed it for some reason. |
What does this PR do?
Adds integration tests for the gem module.
@cachedout Any critique here would be appreciated.
Tests written?
Yes