Support additional eselect parameters. #33876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires the type to be passed in. Other eselect modules appear to ignore any params passed to list. e.g. eselect php list cli Change set command in state to pass action_parameter to get_target_list.
|
The Jenkins failures don't look related to this change. |
| ''' | ||
| List available targets for the given module. | ||
|
|
||
| module | ||
| name of the module to be queried for its targets | ||
|
|
||
| action_parameter | ||
| additional params passed to the defined action | ||
|
|
There was a problem hiding this comment.
Can you add a .. versionadded:: Carbon tag here for this new kwarg?
There was a problem hiding this comment.
Ok, I added a new commit.
|
Hi @jwagoner0 - you're right. Those test failures are not related to your change. I had one small comment that should be addressed and then we can get this in. Otherwise this looks great! |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jun 9, 2016
* upstream/develop: (211 commits) Fix merge error caught by tests Add boto3 to utils call Pylint fix Ensure tht pillar have freshest grains (saltstack#33910) Support additional eselect parameters. (saltstack#33876) Ensure tht pillar have freshest grains Add note about Xenial packages to 2016.3.0 release notes (saltstack#33870) add 2016.3.1 release notes (saltstack#33883) Fixup new groupadd tests for syntax change in 2016.3 Use errno Set master and cloud to log level warning (saltstack#33861) Correct silly mistake Allow socket closes when the socket is disconnected Add support for edge case when Cmd and Entrypoint can't be blanked Remove matcher tests Fix another unit test stacktrace in pkg_resource Fixing more stupid unit tests Fix some more lint Fix/add unit tests for state Fix broken locate.locate function ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows action_parameter to be passed in to get_target_list in the eselect module.
Passes the action_parameter from the set command in the eselect state to get_target_list.
What issues does this PR fix or reference?
The PHP eselect module requires an additional parameter to be passed in to list.
e.g. eselect php list cli
Other eselect modules that require an action_parameter, like java-vm, don't require any additional parameters for list. However, they seem to ignore it, so this change doesn't hurt any modules I tested.
Previous Behavior
The following config would always fail because the old code couldn't get a list of targets for PHP.
New Behavior
The above config now properly sets the PHP version.
Tests written?
No