Don't deep copy context dict values. #33896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this reverted in 2016.11? |
|
I would like to know as well. I'm seeing this come up consistently across our minions. A JDK rpm that is supposed to be downloaded to the minion's salt cache is now taking 138 seconds. Running salt-minion Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This highly speeds up the salt minion.
I'm not sure this is safe but in the same time I found no reason to deep copy context dict values that could be not the only generic python objects but also salt objects like cached connections.
If this will break something, we should reimplement the fix #31164 to find another way to keep returns through state execution, for instance keep the only needed values ('return').
What issues does this PR fix or reference?
#33575
Tests written?
No