Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules.gem int tests: more fixes #33951

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Conversation

jfindlay
Copy link
Contributor

@jfindlay jfindlay commented Jun 10, 2016

What does this PR do?

Use non-default gems to test with and only check for gems that were explicitly installed when testing gem.list.

What issues does this PR fix or reference?

Tests written?

Yes

@cachedout
Copy link
Contributor

This test is failing. Could you please have another look?

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jun 13, 2016
@jfindlay jfindlay force-pushed the gem_tests branch 3 times, most recently from 542ac97 to 83e5559 Compare June 13, 2016 17:14
@cachedout cachedout merged commit 9bd2317 into saltstack:2015.8 Jun 14, 2016
@jfindlay jfindlay deleted the gem_tests branch June 17, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants