Remove loader test for pam module #34002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test in the virtual function was unnecessary. The pam module does not itself rely on any external python or pam libraries. The only function present, pam.read_file(), accepts a file name as a parameter, checks if it exists, and parses the file. There is no reason to avoid loading the module. Fixes saltstack#20809
|
Thanks for grabbing this @lorengordon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the test in the
__virtual__function for thepammodule. The test in the virtual function was unnecessary. The pam module does not itself rely on any external python or pam libraries. Theonly function present, pam.read_file(), accepts a file name as a parameter, checks if it exists, and parses the file. There is no reason to avoid loading the module.
What issues does this PR fix or reference?
Fixes #20809
Previous Behavior
The
pammodule would load only if/usr/lib/libpam.soexisted.New Behavior
The
pammodule will always load, as there is no inherent python or pam library dependency.Tests written?
No