fix launch config creation params #34014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue where the launch configuration could not be created because it was connecting to the default region instead of the specified region.
What issues does this PR fix or reference?
There was no submitted issue for this. It was an issue that was hit this morning for us and we debugged until it was fixed.
Previous Behavior
Given:
the state will fail with due to connecting to the wrong region:
The arguments to
boto_asg.create_launch_configuration
were taken as positional instead of named, and there were additional arguments toboto_asg.create_launch_configuration
. This created an inconsistency between argument lists and therefore the specifiedregion
was getting passed into thevolume_type
argument and consequently the localregion
variable was alwaysNone
for the actual creation of the launch configuration.New Behavior
All parameters have been named to prevent this error.
Tests written?
No