Fix diskusage beacon #34103
Merged
Fix diskusage beacon #34103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop trying to load the entire mount dict as the mount point.
|
@cachedout and @garethgreenaway - Can you guys have a look at this in regards to the changes made in #33474? If this fix is correct, then it may need to be backported since the original change was submitted against 2015.8. |
|
@rallytime Go ahead and backport this. |
|
@cachedout Ok - done in #34176. |
rallytime
added
the
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the diskusage beacon, which looks to have been broken by #33474 ("TypeError: must be string, not dict" when try to check a mount point). This effectively reverts #33474.
What issues does this PR fix or reference?
#33972
Tests written?
No