Don't return bytes if py3 in salt-cloud #34105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cachedout Can you clean up those pylint errors? |
|
@rallytime Thanks. Fixed. |
| 'ascii', 'salt-cloud-force-ascii' | ||
| ) | ||
| if not six.PY3: | ||
| vm_image = config.get_cloud_config_value('image', vm_, __opts__).encode( |
There was a problem hiding this comment.
Don't we still need a vm_image set if we are running python 3? Similar to the change in line 246 above: https://github.com/saltstack/salt/pull/34105/files#diff-e8c33e1c4a43de8e11379a6d5cf064b0R246
There was a problem hiding this comment.
Gah. Yeah. Sorry. Thanks.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jun 22, 2016
* upstream/develop: (25 commits) Support using private IPs (without pubic IPs) (saltstack#34187) Add 'delete' key event to list (saltstack#34189) Don't return bytes if py3 in salt-cloud (saltstack#34105) Raise the correct exception when gitfs lockfile is empty Remove unnecesssary comment Fix diskusage beacon fix salt --summary to count not responding minions correctly (saltstack#34165) doc: add missing dot (saltstack#34175) Typo fix (saltstack#34174) Update docs to match log_level warning default Fix YAML indentation in Apache state docstrings (saltstack#34166) Add integration tests for grains.append Moved imports to top, out of _get_moto_version function Updated version check. Moved check into it's own function Move log message from INFO to DEBUG. Updated test to work with new moto version. Changed strings to unicode Update package dep note to systemd-python for RHEL7 install _active_mounts_openbsd: unbreak output for special filesystems Make docker.absent honor test=true When specifying the SSH identity to use with Git as a salt URL, eg. salt://files/identity, if that file exists outside of the default base environment the file won't be accessible so we need to include the saltenv. ... # Conflicts: # salt/states/git.py
|
Looked. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We used to return bytes instead of unicode, which would make a dict with mixed bytes and unicode. This was a pain and caused tests to fail.
What issues does this PR fix or reference?
Failing py3 compat in salt-cloud
Previous Behavior
A dict that looked like
..{'default': {'disk': 0, 'id': b'1', 'driver': <libcloud.compute.drivers.dimensiondata.DimensionDataNodeDriver object at 0x7f2fcbc769b0>, 'price': 0, 'get_uuid': <bound method UuidMixin.get_uuid of <NodeSize: id=1, name=default, ram=0 disk=0 bandwidth=0 price=0 driver=DimensionData ...>>, 'ram': 0, 'name': b'default', 'uuid': b'94811c79b526d5ef99518ce215d56123cc644067', 'bandwidth': 0, 'extra': {}}}for the test return inunit.cloud.clouds.dimensiondata_test.DimensionDataTestCase.test_avail_sizescc: @techhat @rallytime and @s0undt3ch
@s0undt3ch This affects changes that you made specifically, so please have a quick look if you can.