Support for building with local packages on Debian and Ubuntu #34172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a feature and not a bug fix, correct? It should go in the develop branch. |
cachedout
added
the
Pending-Discussion
|
@cachedout It was part of the delivery for building zeromq 4.0.5 for Ubuntu in 2016.3.1 but too late to be included in the tagging of salt, hence want to get it in branch 2016.3 for the next point release, hence more bug fix than feature. In order to build zeromq 4.0.5 had to consume the locally built libsodium, which is not available from regular Ubuntu repos. |
|
Go Go Jenkins! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows for building packages with previously locally build dependencies on Debian and Ubuntu
What issues does this PR fix or reference?
vmware-archive/salt-pack#78
vmware-archive/salt-pack#71
New Behavior
Will now build packages using previously built local packages
Tests written?
No, ability to build with previously built was sufficient test
Please review Salt's Contributing Guide for best practices.