file.find module: fix handling of broken symlinks #34239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
salt.modules.file.find
function to handle broken symlinks.Use Case
I would like get all symlinks in the directory, some of them are eventually broken (point to non-existent files).
Setup is very simple: standalone Salt Minion 2016.3.1 and following directory layout with broken symlink:
If I query the files just by name it works:
salt-call --local file.find /root name='test*' local: - /root/test2
But...
Previous Behavior
If I would like to get only symlinks among all the files it fails:
New Behavior
My PR fixes this and allows to delete such files:
Tests written?
No