Update chkconfig for xinetd based services #34270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled xinetd based services report as <service> on but the existing code is looking for <service>: on
|
@jfindlay It looks like this change was yours. Could you please take a look at this? |
|
Will do. Thanks Matt Lindesay |
|
Bump again @jfindlay |
|
@jfindlay one more bump to look at this. |
|
Looks fine to me. |
|
Go Go Jenkins! |
1 similar comment
|
Go Go Jenkins! |
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Jul 16, 2016
Fixes the failing test in saltstack#34270
rallytime
pushed a commit
that referenced
this pull request
Jul 16, 2016
Update mock value to match change in #34270.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jul 18, 2016
* upstream/develop: (97 commits) Document how to test for the existence of a log message (saltstack#34738) Use six.iteritems instead of iteritems() in configcomparer Use six.iteritems instead of iteritems() in etcd_util Use six.iteritems instead of iteritems() in psutil_compat Use six.iteritems instead of iteritems() in junos grains Use six.iteritems instead of iteritems() in vultrpy driver Use six.iteritems instead of iteritems() in profitbricks driver Use six.iteritems instead of iteritems() in nova driver Use six.iteritems instead of iteritems() in linode driver Use six.iteritems instead of iteritems() in ec2 driver modules/ebuild: Add handling for InvalidAtom exception (saltstack#34727) Add valid function to mine module. Loop over updated keys in non recursive update Update mock value to match change in saltstack#34270. Add versionadded to "special" option in cron.present state (saltstack#34707) NILinuxRT fix timezone module (saltstack#34710) Add state module to manage InfluxDB databases Add state module to manage InfluxDB users Add influx module for InfluxDB 0.9+ Normalise function argument formatting ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes chkconfig check for Redhat 6 xinetd based services
What issues does this PR fix or reference?
The existing module doesn't detected enabled/disabled chkconfig services
Previous Behavior
Always returns False for xinetd services
New Behavior
Correctly returns True for enabled xinetd services
Tests written?
Yes - modified the existing rh_service.py test
Please review Salt's Contributing Guide for best practices.
Enabled xinetd based services report as on but the existing code is looking for : on