2016.3 mount vfstab support #34283
Merged
2016.3 mount vfstab support #34283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce vfstab support for mount.fstab, entries for opts look a bit
weird. Default are '-' so it will end up as a list containing '-'.
I left this to keep 'opts' the same as for normal fstabs.
Example output:
/dev/fd:
----------
device:
fd
device_fsck:
-
fstype:
fd
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/devices:
----------
device:
/devices
device_fsck:
-
fstype:
devfs
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/etc/dfs/sharetab:
----------
device:
sharefs
device_fsck:
-
fstype:
sharefs
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/proc:
----------
device:
/proc
device_fsck:
-
fstype:
proc
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/system/contract:
----------
device:
ctfs
device_fsck:
-
fstype:
ctfs
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/system/object:
----------
device:
objfs
device_fsck:
-
fstype:
objfs
mount_at_boot:
no
opts:
- -
pass_fsck:
-
/tmp:
----------
device:
swap
device_fsck:
-
fstype:
tmpfs
mount_at_boot:
yes
opts:
- size=2048m
pass_fsck:
-
…tab and mount.rm_vfstab
|
This has been bugging me since yesterday, had more time to night so bit the bullet and fixed the vfstab support too. More stuff coming this weekend, a runner if all goes well. (for develop, not sure I can also submit it against 2016.3) |
|
So the test for rm_fstab was failing due to missing kernel, but it is still failing locally with a patched test. |
|
Seems to be a non-related test failure this time round :) |
|
Can someone give jenkins a poke? @cachedout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add vfstab support (Solaris like platform fstab format)
It bugged me the entire day I didn't fix the fstab parsing for Solaris like platforms, so I added support for vfstab.
New functions
mount.vfstab (wrapper for mount.fstab)
mount.rm_vfstab (wrapper for mount.rm_fstab)
mount.set_vfstab
The wrapper pass the correct file path (/etc/vfstab) to there parent function, the parent functions know how to parse the vfstab format by creating a _vfstab_entry class.
What issues does this PR fix or reference?
N/A
Previous Behavior
fstab returned nothing, rm_fstab and set_fstab did not work either.
New Behavior
vfstab, rm_vfstab en set_vfstab are now working.
Tests written?
Yes (mount.vfstab)
Affected version