2016.3 status module now works on Solaris like platforms #34296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally I wanted to work on a vmadm runner (as I keep needed one :p) but I couldn't really figure out why to easily push one on the master to develop on it in rapid succession. |
|
Seems to be a non-related test failure |
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The salt.module.status module now mostly works on Solaris like platforms.
As a bonus a few things now also work on OpenBSD because FreeBSD/OpenBSD/SunOS have a few compatible code paths.
What issues does this PR fix or reference?
#30493
Previous Behavior
Most stuff did not work on Solaris like platforms.
New Behavior
Now it works.
Tests written?
No, but tested the current unit tests and no breakage
Affects