Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osmajorrelease grain for raspbian #34322

Merged
merged 2 commits into from
Jun 28, 2016

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Jun 27, 2016

What does this PR do?

Adds the osmajorrelease grains for raspberry pi boxes.

What issues does this PR fix or reference?

Fixes #34321

Previous Behavior

salt '*' grains.item osmajorrelease

raspberrypi:
    ----------
    osmajorrelease

New Behavior

root@raspberrypi:/etc# salt '*' grains.item osmajorrelease
raspberrypi:
    ----------
    osmajorrelease:
        8

Tests written?

Yes

@Ch3LL
Copy link
Contributor Author

Ch3LL commented Jun 27, 2016

It looks like osmajorrlease is not available for Ubuntu. Is that by design?

@rallytime
Copy link
Contributor

rallytime commented Jun 27, 2016

@Ch3LL The osmajorrelease grain is largely used for RHEL-based systems. It looks like Debain supports it now since the 2015.5.0 release (see #15461), but it is not supported for Ubuntu.

This is related to this feature request: #9613

Edit: to answer your question, I don't think that is by design. Just not implemented currently. Unless @cachedout knows why osmajorrelease isn't supported on ubuntu.

@rallytime
Copy link
Contributor

@Ch3LL
Copy link
Contributor Author

Ch3LL commented Jun 27, 2016

@rallytime okay I added osmajorrelease to ubuntu and tested with ubuntu14 as well. If you want me to remove osmajorrelease @cachedout let me know and I can go ahead and do that as well. I also fixed the pylint.

@cachedout cachedout merged commit 75aad07 into saltstack:2016.3 Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants