Remove proxy check and additional GetConnection--this makes the proxy… #34353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fail to start. Need to check to see if proxy memory leak is back.
|
ping @gtmanfred |
|
LGTM, i will check if we are still leaking connections once the GetConnection is removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… fail to start. Need to check to see if proxy memory leak is back.
What does this PR do?
Removes the extra GetConnection and check for salt-proxy. This check causes the proxy to fail to start.
Previous Behavior
ESXi proxy minion fails to start with error messages indicating the SSL certificate failed to verify.
New Behavior
ESXi proxy starts successfully.
Tests written?
No