Update service.py

[steverweber]

What issues does this PR fix or reference?

#30660

Previous Behavior

might stop service while in test mode

New Behavior

does not stop service while in test mode

[brc]

@steverweber After reading this PR's description a few times, I don't think it was your intention to imply that my PR was a problem (but it's extremely confusing).

I would have appreciated if you wrote something more clear for the reviewer, such as:

1. PR Revert service.mod_watch() bug introduced in Issue 21084 #30660 reverted bad code in develop, which is a good thing.
2. My PR reverts the same bad code in 2015.8. I am also going to complect the matter by re-introducing the same bad code a different way within the same commit (and PS: it still doesn't even do the right thing)!

This should be two commits. It should probably be two separate PRs (one to revert the broken code and one to discuss a solution for handling the particular type of init scripts you're compensating for).

Enjoy your spaghetti. 🍝

[steverweber]

Sorry didn't try to imply anything about your code revert. You did a good job fixing that bug!

I also agree the solution I pushed is kinda hacky... Your thoughts on using sig are good however this is not always practical... Think I had issues with some init scripts that preformed a 2xfork doing something like ((sh -c 'some bin') 1>/dev/null 2>/dev/null &)& (kinda forget how the demand went) and or sometimes the process name is unknown or kinda random..

Anyways the current PR could be improved.
perhaps also check that reload is not set.

if verb == 'start' and 'service.stop' in __salt__ and not reload: