Fix wrong order of retention_policy_exists. #34507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of retention policy and database were reversed, so SaltStack was using rp name as database, so it returns "database does not exist"
|
Go Go Jenkins! |
|
That was just 1 word 😂 |
|
@aabouzaid Yeah, that failure is unrelated. Thanks for submitting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix wrong order of retention_policy_exists in InfluxDB module.
What issues does this PR fix or reference?
The name of retention policy and database were reversed:
Based on InfluxDB module documentation It should be:
But SaltStack was using rp name as database, so it returns "database does not exist".