Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies the proper way to reference states #34601

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

lorengordon
Copy link
Contributor

@lorengordon lorengordon commented Jul 12, 2016

It seems in some situations, or in some earlier version, using a / to reference sls files in subdirectories did work. However, the inconsistency in when it worked could cause occasional confusion. This updates the tutorial to focus on the canonical . notation, which always works.

It seems in some situations, or in some earlier version, using a `/`
to reference sls files in subdirectories did work. However, because
of the inconsistency it caused occasional confusion. This updates the
tutorial to focus on the canonical `.` notation, which always works.
@lorengordon
Copy link
Contributor Author

A result of a post in the salt user group, https://groups.google.com/d/msg/salt-users/GZJRgOz258s/eQqQzfMqAAAJ.

@cachedout
Copy link
Contributor

I'd like to do a little research here and figure out where this is working and where it isn't. If it's a reasonable fix, let's add a test so it doesn't regress and fix it for good.

@Ch3LL Can you help figure out which branches this is working in and which it isn't?

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jul 12, 2016
@lorengordon
Copy link
Contributor Author

@cachedout, makes sense. I intentionally wasn't changing how the code works. I just figured the tutorial should focus on teaching people the canonical salt syntax, and leave such other details for a more advanced usage doc.

@cachedout
Copy link
Contributor

@lorengordon That's a good point about removing it from a basic tutorial. Let's go ahead and merge this. Would you mind submitting an issue about the broken behavior so that we can evaluate and hopefully fix it?

@cachedout cachedout merged commit 3b6f108 into saltstack:2015.8 Jul 14, 2016
@lorengordon
Copy link
Contributor Author

FWIW, the user responded on the google list that their problem turned out to be minions with very old versions of salt. Apparently, I had the issue backwards...newer versions support / notation, older versions do not. :sigh: I do still think the tutorial portion should focus on a single syntax though, to help reduce confusion and build good habits. :)

@cachedout
Copy link
Contributor

Ahhh, OK. Makes sense. Yes, I agree with you regarding the tutorial. That is a good change.

@lorengordon lorengordon deleted the clarify-doc branch January 8, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants