2016.3 zpool cleanup and fixes #34842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llback to zpool cli error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As pointed out in #34770 the zpool exec module is not very robust in regard to vdev type.
This PR skips all the fancy parsing and falls back to the zpool cli's error messages, allowing the hardcoded list of vdev types to be removed.
There is also one small fix for a bug when passing on/off values via the zpool state + tweaks to make the zpool state module work with the updated exec module.
What issues does this PR fix or reference?
#34770
Previous Behavior
Hardcoded list of vdev types
New Behavior
Removed the hardcoded list from the exec module and state module
Tests written?
No