Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for version in list of installed versions #34864

Merged
merged 2 commits into from
Jul 22, 2016

Conversation

jmacfar
Copy link
Contributor

@jmacfar jmacfar commented Jul 21, 2016

What does this PR do?

2016.3 breaks previous behavior of pkg.(install|remove) in that if multiple versions of one piece of software are installed, none are seen as installed and are not removable. Tested with w2k8/w2k12 client.

Previous Behavior

w8-cl1.salt.local:
    ----------
    Java Auto Updater:
        2.8.91.15
    jre8:
        8.0.730.2,8.0.910.15
    salt-minion:
        2016.3.1

$ salt 'w8-cl1*' pkg.remove jre8 version=8.0.730.2
w8-cl1.salt.local:
    ----------
    jre8:
        ----------
        current:
            8.0.730.2 not installed

$ salt 'w8-cl1*' pkg.remove jre8
w8-cl1.salt.local:
    ----------
    jre8:
        ----------
        current:
            8.0.910.15 not installed

New Behavior

$ salt 'w8-*' pkg.list_pkgs
w8-cl1.salt.local:
    ----------
    Java Auto Updater:
        2.8.91.15
    jre8:
        8.0.730.2,8.0.910.15
    salt-minion:
        2016.3.1

$ salt 'w8-*' pkg.remove jre8 version=8.0.730.2
w8-cl1.salt.local:
    ----------
    jre8:
        ----------
        new:
            8.0.910.15
        old:
            8.0.730.2,8.0.910.15

$ salt 'w8-*' pkg.remove jre8
w8-cl1.salt.local:
    ----------
    jre8:
        ----------
        new:
        old:
            8.0.910.15

Tests written?

No

@rallytime
Copy link
Contributor

@jmacfar Just a small lint error - can you clean that up really quickly? Then we can get this in.

@rallytime rallytime merged commit 815ffdf into saltstack:2016.3 Jul 22, 2016
@damon-atkins
Copy link
Contributor

Can this be pushed into dev please, as it seems to of been push into 2016.3

@rallytime
Copy link
Contributor

It will be merged into develop in the next round of merge-forwards.

@jmacfar jmacfar deleted the winpkg_version branch August 22, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants