Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk.wipe missing option. #35253

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Conversation

abednarik
Copy link
Contributor

What does this PR do?

Added -a option to wipefs in disk.,wipe to actually wipe partition.

What issues does this PR fix or reference?

#35234

Previous Behavior

When using disk.wipe salt don'r really remove that partition, just shows it

----------------------------------------------------------------
0x438                ext4   [filesystem]
                     UUID:  4ad1a0ff-4784-4301-84b7-0cec92b6fa3b

New Behavior

Partition is removed.

Tests written?

No

Also added en else clause in case the cmd retcode is not 0. This can be the case when trying to wipe a non-existant partition.

Added -a option to wipefs in disk.,wipe to actually wipe partition.
@cachedout
Copy link
Contributor

I'll cleanup the failing test in a follow-up PR. Thanks, @abednarik

@cachedout cachedout merged commit 4e7d7f8 into saltstack:2016.3 Aug 6, 2016
@abednarik
Copy link
Contributor Author

Ok, thanks Mike. I can do it if you want.

Cheers

@cachedout
Copy link
Contributor

I got it. Thanks, @abednarik

@cachedout cachedout mentioned this pull request Aug 6, 2016
@abednarik abednarik deleted the disk_wipe_fix branch August 7, 2016 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants