document log levels and warn on all logging below info #35356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Document log levels and warn about sensitive data on all logging below info
I also wanted to warn on insecure levels of
log_level_logfile
, but this is not possible at present because of the following complications:Running a check in
salt.utils.verify.verify_log
againstlog_level_logfile
results in that config being set toNone
because that is what it is insalt.config
.salt.minion
andsalt.utils.cloud
both setlog_level_logfile
toinfo
as advertised by the logging docs and the minion config docs, but these are all incorrect and preempted bysalt.utils.parsers
, which setslog_level_logfile
indiscriminately towarning
. I have also verified this with a 2016.3.2 install.If advised, I will submit another pull request against develop unifying these contradictory defaults to
warning
orinfo
and update the release notes. I thinkwarning
would be better since that is what effectively happens and we should changesalt.minion
andsalt.utils.cloud
and the docs to that.In my opinion,
salt.config
should be considered the authority on option defaults so that, for example,salt.utils.parsers
can source its defaults from there rather than provide duplicate or contradictory defaults. What do you think, @s0undt3ch?What issues does this PR fix or reference?
none
Tests written?
Yes