Clean up open filehandles #35359
Merged
Clean up open filehandles #35359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terminalmage Can you fix up those lint errors? Once the lint is cleaned up in the |
rallytime
added
the
Pending-Discussion
|
Working on lint/tests |
terminalmage
force-pushed
the
audit-filehandles
branch
from
977a7a3
to
755bc37
Compare
rallytime
removed
the
Pending-Discussion
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Aug 15, 2016
* upstream/develop: (92 commits) Add example yaml to win_snmp state (saltstack#35435) Fix os_family check in zypper module (saltstack#35450) Make sha256 the default hash_type Add example yaml to win_smtp_server state Fix some items that went awry in the merge Pass saltenv to call to latest_version in list_upgrades function Provide links to the renderers in the template docs (saltstack#35406) Fixed 'os' and 'os_family' grains for SUSE systems tests and remote_ip renamed to remoteip as per netsh w/o _ remoteip for win_firewall modules.event.send(): Also check for `file_client` and `use_master_when_local` opts Add example yaml to win_pki state Bug fixes for github module (saltstack#35397) None will not be added to grains which generate [none] Lint fix Update freebsd.rst (saltstack#35394) Raise SaltRenderError on bad requisite (saltstack#35373) Clean up open filehandles (saltstack#35359) Update grains unit tests: osmajorrelease grain is a str, not an int. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up about 100 places where we're leaving filehandles open.