No need to run ddns update every time #35393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... - only if we're replacing record and record not exists.
After applying f0dbbd5 update() in ddns execute module never returns
None.(Compare with old code - https://github.com/saltstack/salt/blob/2015.5/salt/modules/ddns.py#L162-L173)
But
Noneis still used in the corresponding state for change detection - https://github.com/saltstack/salt/blob/develop/salt/states/ddns.py#L73-L89This PR makes update() return None if no updates are needed.
What does this PR do?
Fixing issue #35350 - now Salt emits ddns updates only when needed.
What issues do this PR fix or reference?
#35350
Previous Behavior
DDNS record was updated every Salt run.
New Behavior
DDNS record is updating if needed.
Tests written?
No