fix 20575, make subset really return random subset #35720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much, @hu-dabao |
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Aug 24, 2016
This was referenced Aug 24, 2016
thatch45
added a commit
that referenced
this pull request
Aug 25, 2016
Fixup the unit.client_test.LocalClientTestCase.test_cmd_subset from #35720
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Aug 26, 2016
* upstream/develop: Implement suggestions of bytes vs str type for saltstack#35593 (saltstack#35783) Developer documentation for Unicode handling (saltstack#35593) Bump template context deprecation to Nitrogen (saltstack#35776) Revert "Template context must be populated with key:value pairs" (saltstack#35770) Add cmd_mock back in to function spec Fixup the unit.client_test.LocalClientTestCase.test_cmd_subset from saltstack#35720 Add versionadded for enabled function in apache_module state (saltstack#35732) Remove docs mocks for msgpack and psutils fix 20575, make subset really return random subset Make test runs behave better (saltstack#35708) use aws.get_location in s3 modules fix maximum recursion depth Don't use six.text_type() in salt.utils.gitfs Fixup doc formatting for the sqs_events engine (saltstack#35663) Fix user.present state reporting for groups when remove_groups=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #20575
subnet options can really return subnet with random elements.
What issues does this PR fix or reference?
Previous Behavior
As #20575 described.
New Behavior
Target will be random hosts.
Tests written?
No
Please review Salt's Contributing Guide for best practices.