Fix #35741 #35796
Merged
Fix #35741 #35796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix saltstack#35741 . HTTP Credentials are now used in the right order.
|
Thank you very much @fix7! |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Aug 29, 2016
* upstream/develop: (53 commits) Lint whitespace Raise to 5s per @techhat Fix lint and missing value Lint Lint Ensure ssh keys are decodable before inserting Fix traceback in salt-cloud logging for Azure Fix regex bug Update inotify.py beacon Don't test for linux shells on Windows (saltstack#35743) fix 34241, webutil.useradd_all is deprecated (saltstack#35788) Updated user.py to redact password when test=true Bump the deprecation warning in pkgrepo state to Nitrogen (saltstack#35810) Fix misuse of HTTP credentials in modjk execution module (saltstack#35796) Schedule documentation update (saltstack#35745) Better unicode handling in gitfs (saltstack#35802) Adds mock for tornado.locks (saltstack#35807) Bump the deprecation warning in pkgrepo state to Nitrogen (saltstack#35806) Bump the deprecation warnings in glance module to Nitrogen (saltstack#35805) Bump the deprecation warning in salt.client.mixins.py to Nitrogen (saltstack#35804) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correct use of HTTP credentials in modjk execution module,
What issues does this PR fix or reference?
#35741
Previous Behavior
Credentials fed are misused. All authentication process is broken and any call ends in 401 traceback.
New Behavior
Access to a password protected mod_jk web API works.
Tests written?
No