Add more helpful return messages for drac runner #35868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also be more helpful and protect against a KeyError and stacktrace when the "drac" username and password are not in the master config file or passed in at the CLI.
|
I think this message could be improved. Could we link to documentation or at least list precisely which values need to be set for this to work properly? |
cachedout
added
the
Pending-Discussion
|
@cachedout How does that look now? I am open to ideas for how to improve providing configuration information at the CLI/in the logs. |
|
Perfect! Thanks much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also be more helpful and protect against a KeyError and stacktrace when the "drac" username and password are not in the master config file or passed in at the CLI.
Fixes #35825