Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: fix formatting of consul.agent_join #36061

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

multani
Copy link
Contributor

@multani multani commented Sep 5, 2016

What does this PR do?

This patch removes the wrong copy/paste and the usage of the undefined enable argument.

What issues does this PR fix or reference?

None

Previous Behavior

Using the consul.agent_join function raises a KeyError: 'enable' message, cf. the code in https://github.com/saltstack/salt/blob/develop/salt/modules/consul.py#L612

  • there's no reference to enable anywhere, and it is not documented anywhere
  • actually, the message formatted which causes this error is completely unrelated to the "join" function of Consul, and looks to be a copy/paste from the agent_maintenance function

Tests written?

No

@rallytime
Copy link
Contributor

Thanks @multani

@rallytime rallytime merged commit fa09050 into saltstack:2015.8 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants