[WIP] Add additional required dll's for Windows #36096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def run(self): | ||
| if getattr(self.distribution, 'salt_installing_pyyaml_windows', None) is None: | ||
| print('This command is not meant to be called on it\'s own') |
cachedout
added
the
Pending-Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing DLL's and prereqs for Windows setup.
What issues does this PR fix or reference?
Partial fix for #33848
Previous Behavior
Not being installed if installing with setup.py
New Behavior
Now installs additional files
Tests written?
NA