Add ability to specify disk backing mode for VMware cloud profile #36334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass-by-value
force-pushed
the
vmware_driver_specify_disk_mode
branch
from
aacde82
to
51d9aa2
Compare
|
@pass-by-value You're |
rallytime
added
the
Pending-Discussion
pass-by-value
force-pushed
the
vmware_driver_specify_disk_mode
branch
from
51d9aa2
to
bc5c965
Compare
|
Thanks for catching this @rallytime!! I updated the |
|
Great! Thanks @pass-by-value! |
rallytime
removed
the
Pending-Discussion
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Sep 19, 2016
* commit 'faae3da84c867282a84aa5deddad5e14556754d8': Add 'coalesce' option to inotify beacon (saltstack#36404) Removes extra empty lines in the disk specificity example (saltstack#36410) Add ability to specify disk backing mode for VMware cloud profile (saltstack#36334) Update carbon.rst (saltstack#36395) Some modules (e.g. boto_* ones) require utils to be loaded. (saltstack#36398)
meggiebot
added
the
bugfix-bckport
|
@rallytime - @thatch45 has approved a backport of this to 2016.3 |
|
Ok. Done in #37245 |
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We're now able to specify a virtual disk backing mode in the cloud profile. This is applicable to the VMware (salt cloud) related functionality.
What issues does this PR fix or reference?
ZH 926
Previous Behavior
We could specify size and the sata controller for virtual disk.
New Behavior
We can now specify the mode as well
Tests written?
No
Please review Salt's Contributing Guide for best practices.