Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows requirements file #36384

Merged
merged 1 commit into from
Sep 17, 2016
Merged

Add windows requirements file #36384

merged 1 commit into from
Sep 17, 2016

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Sep 16, 2016 •
edited
Loading

What does this PR do?

Adds a requirements file for Windows. Also goes back to https for download links.

What issues does this PR fix or reference?

#33848

Previous Behavior

Salt was installed without required dependencies on Windows

New Behavior

Minimum dependencies are installed

Tests written?

No

cachedout
cachedout approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are just in a requirements file, they do not need a review of their licenses since they don't constitute a software bundle. Looks good.

@cachedout cachedout merged commit 373c5db into saltstack:2015.8 Sep 17, 2016
@twangboy twangboy deleted the update_setup_req branch September 20, 2016 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twangboy @cachedout