Avoid disk hit for renderer generation on pillar instantiation #36525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, both salt-call and MWorkers would hit the disk to pull all of the renderers on each pillar generation. This should provide a marginal peformance increase for both.
|
@thatch45 and @DmitryKuzmenko Could one or both of you please look this over? |
thatch45
approved these changes
Sep 26, 2016
|
Yes, this looks good. |
|
Looks good for me. |
|
I broke a case where in masterless mode, we need to be able to see grains inside pillars. (#38641). Reverting. |
|
@cachedout also #39008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, both salt-call and MWorkers would hit the disk to pull all of the renderers on each pillar generation. This should provide a marginal peformance increase for both.