Mercurial Module: Pass the identity_path portion as own arg #36546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we pass in an identity file to use with the
--ssh
option in thehg.py
execution module, thessh -i <identity file>
portion needs to be passed along as its own arg in the list of command args passedcmd.run
.What issues does this PR fix or reference?
Fixes #36514
Previous Behavior
When using the mercurial sate with the
identity
option set, the state would fail because the--ssh "ssh -i /indentity/file"
way of passing the command was tripping up thecmd.run
call:New Behavior
The list of args are passed correctly to the
cmd.run
function and we no longer have an error.Tests written?
No
Please review Salt's Contributing Guide for best practices.