Add support for rpmdevtools returning < / > / ==

[edhgoose]

What does this PR do?

Fixes #36738, where rpmdevtools returns different syntax on AWS Linux

What issues does this PR fix or reference?

#36738

Tests written?

No

Please review Salt's Contributing Guide for best practices.

rpmdevtools versions can return "<", ">" or "==" instead of "is newer". This adds support for those and fixes #36738.

[cachedout]

@terminalmage Can you take a look here please?

[terminalmage]

This looks solid. I coded the initial vercmp support based on the versions available in CentOS 5 and 6, and never saw this output in either. I recall trying to see if we could just interpret the results via the retcode, but for some reason decided not to. Perhaps it's time to revisit this, though. Can you replicate the following commands, which I just ran on CentOS 7, on your AWS instance?

[root@cent7 /]# rpmdev-vercmp 1.2.3-1 1.2.3-1 >/dev/null; echo $?
0
[root@cent7 /]# rpmdev-vercmp 1.2.3-2 1.2.3-1 >/dev/null; echo $?
11
[root@cent7 /]# rpmdev-vercmp 1.2.3-1 1.2.3-2 >/dev/null; echo $?
12

[terminalmage]

If the retcodes on your AWS box match the example above, then #36754 (which I just opened) might be a better alternative.

I tried this on Cent5, Cent6, and Cent7 and all have the same retcodes for each outcome.

[edhgoose]

@terminalmage Yes, I can confirm my version works the same.

[user@host current]$ rpmdev-vercmp 1.2.3-1 1.2.3-1 >/dev/null; echo $?
0
[user@host current]$ rpmdev-vercmp 1.2.3-2 1.2.3-1 >/dev/null; echo $?
11
[user@host current]$ rpmdev-vercmp 1.2.3-1 1.2.3-2 >/dev/null; echo $?
12

[terminalmage]

OK, would you be able to test #36754 to see if it works for you?

[edhgoose]

I can confirm that #36754 works for me. I'll close this.

[cachedout]

@edhgoose Thanks! I will go ahead and merge #36754 then. I appreciate you getting back to us so quickly. :]