allow for closing stuff in beacons #36808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just have the beacon check for a running state? This feels like a bunch of unnecessary overhead and complexity. |
cachedout
added
the
Pending-Discussion
|
So if we were to do that, we would have to move handling of 'disable_during_state_run' to each beacon, where as right now we are skipping running the beacon function at all if this setting is set. Actually, another way to do it would be to check disable_during_state_run until after the beacon runs, and then just throw away any events that would be returned instead of not running the beacon, that would solve both problems? |
Like the filehandler for inotify
|
Oh, this is far better, it would be bad if the beacons all hit the disk checking for whether a state run was going all the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
allow for closing file handlers in the inotify beacon when disable_during_state_run is enabled.