[develop] salt.modules.at was hopelessly broken on Solaris-like platforms

[sjorge]

What does this PR do?

• update salt.modules.at to use virtualname
• update salt.modules.at virtual() to return false on SunOS platform
• improve salt.modules.at to only compute the regex once in atq
• create salt.modules.at_solaris with virtualname of at
• update salt.states.at to use new salt.module.at calls
• cleanup salt.states.at
• added unique_tag property to at.present*
• added mod_watch to salt.states.at, because I really want this*

salt.modules.at_solaris is compatible in output with salt.modules.at

Some cleanup happened along the way, that could probably also happen to salt.modules.at

What issues does this PR fix or reference?

N/A

Previous Behavior

All at.* calls would raise exceptions on Solaris-like platforms.

New Behavior

All at.* calls now work fine on Solaris-like platforms (tested on Solaris 10, OmniOS and SmartOS)

Although the Solaris 10 box got minimal testing, it was a prod box from work down for maintenance -- why I could test in the first place.

Tests written?

Yes

• this will be sweet in combination with watching the salt-minion config for changes and doing a delayed restart! Which to be honest was the whole reason for me taking a look at this.

[sjorge]

@cachedout

Is it acceptable to do a 2nd PR to clean up salt.modules.at and use the jenkins pipeline for testing?
As I lack Linux minions, I only have one that is using lx branded emulation.

[sjorge]

Unfortunately salt.states.at is still broken, will fix this to use at.* in all cases.

[sjorge]

salt.states.at was actually pretty horrible :(

• changed all cmd_run calls to at.* module calls
• code cleanup
• improved docs
• implemented jobid (was mentioned but not done)

Changes to the return of the state were unavoidable. If tests break I will fix after jenkins run.

[sjorge]

Updated the checks for the at state, now mock data is injected for the at.at, at.jobcheck, at.atrm module functions. The result was also updated to reflect the new result data.

[rallytime]

Thank you very much @sjorge for this. Looks great!