Fix race condition in which files were removed during a file.directory #36928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a case in which a directory being managed by a file.directory state was running a sphinx build, and temporary files/dirs created by the build were present when the initial walk was performed but were cleaned up by the time the state got around to enforcing permissions.
|
This may still require some testing, I wasn't able to properly test the race condition so I think I'll need to test this by inserting bogus file/directory names into the walk results so that I can force the state to try to check their perms. |
|
This would also be a good candidate for an automated test. |
rallytime
added
the
Needs-Testcase
|
OK I tested by injecting a bogus file into the walk results, and was able to trigger the traceback without the fix, and show that the error no longer occurs when the fix is applied. This should be good to merge. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a case in which a directory being managed by a
file.directory state was running a sphinx build, and temporary
files/dirs created by the build were present when the initial walk was
performed but were cleaned up by the time the state got around to
enforcing permissions.
Resolves #36831.