salt.modules.gpg: allow getting keys by short key ID #37087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It restores the ability of the
gpg
exec module to handle short GnuPG key IDs (last 8 chars of the fingerprint) in such functions asget_key
,get_secret_key
,delete_key
andtrust_key
. Also, fixed some docstrings.What issues does this PR fix or reference?
Modern versions of
python-gnupg
module always return long key ID (16 chars) as a result of callinglist_keys()
method. But the documentation for the Saltgpg
module clearly says that you're able to use short key IDs in the example sections. This PR allows to use both short and long key ID as an argument for the functions mentioned above.Previous Behavior
I've imported public key into my keyring.
But, unfortunately, I can't get information about it directly.
New Behavior
Now
gpg
module supports short key IDs as well:Tests written?
No